linux-kernel - Re: [PATCH v6 3/6] ARM: dts: spear13xx: Fix sata node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220314034940.rxkgue2kllnqhucp@vireshk-i7>
Date:   Mon, 14 Mar 2022 09:19:40 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Frank Wunderlich <linux@...web.de>
Cc:     devicetree@...r.kernel.org,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Viresh Kumar <vireshk@...nel.org>,
        Shiraz Hashim <shiraz.linux.kernel@...il.com>, soc@...nel.org,
        Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Heiko Stuebner <heiko@...ech.de>,
        Peter Geis <pgwipeout@...il.com>,
        Michael Riesch <michael.riesch@...fvision.net>,
        Hans de Goede <hdegoede@...hat.com>,
        Jens Axboe <axboe@...nel.dk>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v6 3/6] ARM: dts: spear13xx: Fix sata node name

On 11-03-22, 22:03, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@...lic-files.de>
> 
> After converting the binding to yaml the node name does
> not match the standard pattern, change it.
> 
> arch/arm/boot/dts/spear1340-evb.dt.yaml: ahci@...00000:
> $nodename:0: 'ahci@...00000' does not match '^sata(@.*)?$'
> 	From schema: Documentation/devicetree/bindings/ata/ahci-platform.yaml
> 
> Fixes: 07658d9a659b ("SPEAr13xx: Add dts and dtsi files")

I don't think this is correct. The above patch is correct. The first
patch in this series changes the names and that's where things break.

I think you could have added these patches before changing to yaml and
then nothing would ever have broken.

Since this isn't a big deal anyway, I think you can just drop the
Fixes tag here, and other dts patches you have.

-- 
viresh