linux-kernel - Re: [PATCH v2 -next] i2c: designware: Remove code duplication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOtMz3OM9c7NpGiYVHxs+KOVBVNykbQkj+KarBbNtUt6iiiQCw@mail.gmail.com>
Date:   Mon, 14 Mar 2022 09:56:16 +0100
From:   Jan Dąbroś <jsd@...ihalf.com>
To:     Wolfram Sang <wsa@...nel.org>, Jan Dabros <jsd@...ihalf.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        upstream@...ihalf.com
Subject: Re: [PATCH v2 -next] i2c: designware: Remove code duplication

Hi Wolfram,

pt., 11 mar 2022 o 21:51 Wolfram Sang <wsa@...nel.org> napisał(a):
>
> On Thu, Mar 10, 2022 at 11:09:32PM +0100, Jan Dabros wrote:
> > Simplify code by moving common part to one function.
> >
> > Signed-off-by: Jan Dabros <jsd@...ihalf.com>
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> Is it really based on for-next? I can't apply the patch. Am I missing
> something?

I checked this once again and I mistakenly used the old linux-next
baseline. Actually the cherry-pick of the above patch was successful,
but I confirmed "git am" is not happy because of the missing semicolon
in one of the lines from context. Baseline for v2 doesn't include
1e4fe5430b: "i2c: designware: remove unneeded semicolon" thus the
problem.

Sorry for the confusion, I will send v3 rebased on top of fresh -next.

Best Regards,
Jan