linux-kernel - Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Warning found by checkpatch.pl script.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Mar 2022 16:48:47 +0530
From:   shaikh kamaluddin <shaikhkamal2012@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <brauner@...nel.org>,
        Hridya Valsaraju <hridya@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with
 const keyword Warning found by checkpatch.pl script.

On 3/13/2022 2:57 AM, Joe Perches wrote:
> On Sun, 2022-03-13 at 03:11 +0530, shaikh kamal wrote:
> []
>> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> []
>> @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>>   
>>   static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>>   {
>> -	static struct file_operations vmfile_fops;
>> +	static const struct file_operations vmfile_fops;
> 
> Make sure to compile any files modified by your suggested patches
> _before_ sending the patches.
> 
> 

Thanks for your suggestion, Kernel build is failing.