linux-kernel - Re: [PATCH 4.19 01/34] cgroup/cpuset: Fix a race between cpuset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220314111940.GC1035@blackbody.suse.cz>
Date:   Mon, 14 Mar 2022 12:19:41 +0100
From:   Michal Koutný <mkoutny@...e.com>
To:     Zhang Qiao <zhangqiao22@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Zhao Gongyi <zhaogongyi@...wei.com>,
        Waiman Long <longman@...hat.com>, Tejun Heo <tj@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>
Subject: Re: [PATCH 4.19 01/34] cgroup/cpuset: Fix a race between
 cpuset_attach() and cpu hotplug

Hello.

In my opinion there are two approaches:
a) drop this backport (given other races present),
b) swap the locks compatible with v4.19 as this patch proposes.

On Mon, Mar 14, 2022 at 05:11:50PM +0800, Zhang Qiao <zhangqiao22@...wei.com> wrote:
> +       /*
> +        * It should hold cpus lock because a cpu offline event can
> +        * cause set_cpus_allowed_ptr() failed.
> +        */
> +       cpus_read_lock();

Maybe just a nit, the old kernels before commit c5c63b9a6a2e ("cgroup:
Replace deprecated CPU-hotplug functions.") v5.15-rc1~159^2~5
would be more consistent with get_online_cpus() here (but they're
equivalent functionally so the locking order is correct).

Michal