linux-kernel - Re: [PATCH -next] ubifs: rename_whiteout: correct old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <157336576.152785.1647468012272.JavaMail.zimbra@nod.at>
Date:   Wed, 16 Mar 2022 23:00:12 +0100 (CET)
From:   Richard Weinberger <richard@....at>
To:     libaokun <libaokun1@...wei.com>
Cc:     linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        yukuai3 <yukuai3@...wei.com>,
        chengzhihao1 <chengzhihao1@...wei.com>
Subject: Re: [PATCH -next] ubifs: rename_whiteout: correct old_dir size
 computing

----- Ursprüngliche Mail -----
> Von: "libaokun" <libaokun1@...wei.com>
> An: "richard" <richard@....at>, "linux-mtd" <linux-mtd@...ts.infradead.org>, "linux-kernel"
> <linux-kernel@...r.kernel.org>
> CC: "yukuai3" <yukuai3@...wei.com>, "chengzhihao1" <chengzhihao1@...wei.com>, "libaokun" <libaokun1@...wei.com>
> Gesendet: Donnerstag, 10. März 2022 09:32:57
> Betreff: Re: [PATCH -next] ubifs: rename_whiteout: correct old_dir size computing

> A gentle ping, sorry for the noise.

I have to say sorry for the day.
Thanks for your patience with me.
 
> 
> 在 2022/2/15 12:07, Baokun Li 写道:
>> When renaming the whiteout file, the old whiteout file is not deleted.
>> Therefore, we add the old dentry size to the old dir like XFS.
>> Otherwise, an error may be reported due to `fscki->calc_sz != fscki->size`
>> in check_indes.
>>
>> Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT")
>> Reported-by: Zhihao Cheng <chengzhihao1@...wei.com>
>> Signed-off-by: Baokun Li <libaokun1@...wei.com>
>> ---
>>   fs/ubifs/dir.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
>> index ae082a0be2a3..86151889548e 100644
>> --- a/fs/ubifs/dir.c
>> +++ b/fs/ubifs/dir.c
>> @@ -1402,6 +1402,9 @@ static int do_rename(struct inode *old_dir, struct dentry
>> *old_dentry,
>>   			iput(whiteout);
>>   			goto out_release;
>>   		}
>> +
>> +		/* Add the old_dentry size to the old_dir size. */
>> +		old_sz -= CALC_DENT_SIZE(fname_len(&old_nm));

So you basically reset old_sz back to 0?

Thanks,
//richard