linux-kernel - Re: [PATCH v3] kallsyms: enhance %pS/s/b printing when KALLSYSMS is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Mar 2022 01:25:27 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Michal Suchánek <msuchanek@...e.de>
Cc:     Maninder Singh <maninder1.s@...sung.com>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "senozhatsky@...omium.org" <senozhatsky@...omium.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "linux@...musvillemoes.dk" <linux@...musvillemoes.dk>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "wangkefeng.wang@...wei.com" <wangkefeng.wang@...wei.com>,
        "v.narang@...sung.com" <v.narang@...sung.com>,
        "swboyd@...omium.org" <swboyd@...omium.org>,
        "ojeda@...nel.org" <ojeda@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "avimalin@...il.com" <avimalin@...il.com>,
        "atomlin@...hat.com" <atomlin@...hat.com>
Subject: Re: [PATCH v3] kallsyms: enhance %pS/s/b printing when KALLSYSMS is
 disabled

On Wed, Mar 16, 2022 at 06:40:02AM +0000, Christophe Leroy wrote:
> Hi Luis
> 
> 
> Le 15/03/2022 à 18:52, Luis Chamberlain a écrit :
> > On Tue, Mar 15, 2022 at 09:21:00PM +0530, Maninder Singh wrote:
> >>   include/linux/kallsyms.h |  2 +
> >>   include/linux/module.h   | 20 ++++++++++
> >>   kernel/kallsyms.c        | 27 +++++++------
> >>   kernel/module.c          |  4 +-
> >>   lib/vsprintf.c           | 85 ++++++++++++++++++++++++++++++++++------
> > 
> > Hey Maninder, thanks for your patch!
> > 
> > Since this touches kernel/module.c and include/linux/module.h I'd prefer
> > this go through modules-next [0], and as you will see that's a different
> > world right now. I also have a set of at least 2 other patch sets to
> > merge there before yours.
> > 
> > Also, what is on modules-next is not intended to go to Linus for the
> > next merge window as the changes there got merged only late, and I want
> > at least 2 months of testing on linux-newt before any pull requiest is
> > sent to Linus.
> > 
> > Can you rebase to modules-next? I can evaluate the patches then for
> > integration there once the other stuff gets merged into that tree too.
> > 
> > [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next
> > 
> 
> I can't see Aaron's series on modules-next yet, do you plan to merge it 
> anytime soon ?
> 
> As you say, it will be a different world by then.
> 
> I have my series rebases on top of latest Aaron's series, but I was 
> waiting that it lands in modules-next. How do you plan to proceed ?

Yes sorry about that, modules-testing is what had Aaron's code. And
Aaron noted that from his series 13/14 and 14/14 from his series
had their Message-Id modified accidently via git-send-email. Given
*current events* and since I use b4 am to verify KSIM signatures
I asked Aaron to wait and post a v12 to aggregate further reviews
and acked-by's. The reason being that if his v11 series has issues
I rather start from a very clean patchset.

Yes I am paranoid :)

Anyway so Aaron, let's give it a few more days, and please then post a
v12 collecing all new tags, then I'll apply your changes and then try to
apply Christophe's.

There was some work by Michal Suchánek which would go after, but
its unclear if that's yet vetted by their other respective maintainers.
Michal?

Anyway, your stuff is at the end of the train after Michal's if that
stuff is really ready. So please don't be surprised if you later have
to rebase once again, or two or 3 times more. Thanks for your patience.

I know this has been quite a bit of churn, but given Aaron's series I
really hope we're goint to be in a better place for maintenance for
modules long term.

I guess I gotta go automate tests to these things somehow too.

  Luis