lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <202203162123.Ksr0CtpZ-lkp@intel.com>
Date:   Wed, 16 Mar 2022 21:42:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Guo Ren <guoren@...ux.alibaba.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: [csky-linux:riscv_compat_v8 20/20]
 arch/riscv/kernel/compat_signal.c:199:5: warning: no previous prototype for
 function 'compat_setup_rt_frame'

tree:   https://github.com/c-sky/csky-linux riscv_compat_v8
head:   5e16532e9a75c08518ff196285fe079ee12188ae
commit: 5e16532e9a75c08518ff196285fe079ee12188ae [20/20] riscv: compat: Add COMPAT Kbuild skeletal support
config: riscv-randconfig-r033-20220313 (https://download.01.org/0day-ci/archive/20220316/202203162123.Ksr0CtpZ-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a6ec1e3d798f8eab43fb3a91028c6ab04e115fcb)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/c-sky/csky-linux/commit/5e16532e9a75c08518ff196285fe079ee12188ae
        git remote add csky-linux https://github.com/c-sky/csky-linux
        git fetch --no-tags csky-linux riscv_compat_v8
        git checkout 5e16532e9a75c08518ff196285fe079ee12188ae
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/riscv/kernel/compat_signal.c:199:5: warning: no previous prototype for function 'compat_setup_rt_frame' [-Wmissing-prototypes]
   int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
       ^
   arch/riscv/kernel/compat_signal.c:199:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
   ^
   static 
   1 warning generated.


vim +/compat_setup_rt_frame +199 arch/riscv/kernel/compat_signal.c

45847575ba9c88 Guo Ren 2021-12-13  198  
45847575ba9c88 Guo Ren 2021-12-13 @199  int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
45847575ba9c88 Guo Ren 2021-12-13  200  	struct pt_regs *regs)
45847575ba9c88 Guo Ren 2021-12-13  201  {
45847575ba9c88 Guo Ren 2021-12-13  202  	struct compat_rt_sigframe __user *frame;
45847575ba9c88 Guo Ren 2021-12-13  203  	long err = 0;
45847575ba9c88 Guo Ren 2021-12-13  204  
45847575ba9c88 Guo Ren 2021-12-13  205  	frame = compat_get_sigframe(ksig, regs, sizeof(*frame));
45847575ba9c88 Guo Ren 2021-12-13  206  	if (!access_ok(frame, sizeof(*frame)))
45847575ba9c88 Guo Ren 2021-12-13  207  		return -EFAULT;
45847575ba9c88 Guo Ren 2021-12-13  208  
45847575ba9c88 Guo Ren 2021-12-13  209  	err |= copy_siginfo_to_user32(&frame->info, &ksig->info);
45847575ba9c88 Guo Ren 2021-12-13  210  
45847575ba9c88 Guo Ren 2021-12-13  211  	/* Create the ucontext. */
45847575ba9c88 Guo Ren 2021-12-13  212  	err |= __put_user(0, &frame->uc.uc_flags);
45847575ba9c88 Guo Ren 2021-12-13  213  	err |= __put_user(NULL, &frame->uc.uc_link);
45847575ba9c88 Guo Ren 2021-12-13  214  	err |= __compat_save_altstack(&frame->uc.uc_stack, regs->sp);
45847575ba9c88 Guo Ren 2021-12-13  215  	err |= compat_setup_sigcontext(frame, regs);
45847575ba9c88 Guo Ren 2021-12-13  216  	err |= __copy_to_user(&frame->uc.uc_sigmask, set, sizeof(*set));
45847575ba9c88 Guo Ren 2021-12-13  217  	if (err)
45847575ba9c88 Guo Ren 2021-12-13  218  		return -EFAULT;
45847575ba9c88 Guo Ren 2021-12-13  219  
45847575ba9c88 Guo Ren 2021-12-13  220  	regs->ra = (unsigned long)COMPAT_VDSO_SYMBOL(
45847575ba9c88 Guo Ren 2021-12-13  221  			current->mm->context.vdso, rt_sigreturn);
45847575ba9c88 Guo Ren 2021-12-13  222  
45847575ba9c88 Guo Ren 2021-12-13  223  	/*
45847575ba9c88 Guo Ren 2021-12-13  224  	 * Set up registers for signal handler.
45847575ba9c88 Guo Ren 2021-12-13  225  	 * Registers that we don't modify keep the value they had from
45847575ba9c88 Guo Ren 2021-12-13  226  	 * user-space at the time we took the signal.
45847575ba9c88 Guo Ren 2021-12-13  227  	 * We always pass siginfo and mcontext, regardless of SA_SIGINFO,
45847575ba9c88 Guo Ren 2021-12-13  228  	 * since some things rely on this (e.g. glibc's debug/segfault.c).
45847575ba9c88 Guo Ren 2021-12-13  229  	 */
45847575ba9c88 Guo Ren 2021-12-13  230  	regs->epc = (unsigned long)ksig->ka.sa.sa_handler;
45847575ba9c88 Guo Ren 2021-12-13  231  	regs->sp = (unsigned long)frame;
45847575ba9c88 Guo Ren 2021-12-13  232  	regs->a0 = ksig->sig;                     /* a0: signal number */
45847575ba9c88 Guo Ren 2021-12-13  233  	regs->a1 = (unsigned long)(&frame->info); /* a1: siginfo pointer */
45847575ba9c88 Guo Ren 2021-12-13  234  	regs->a2 = (unsigned long)(&frame->uc);   /* a2: ucontext pointer */
45847575ba9c88 Guo Ren 2021-12-13  235  

:::::: The code at line 199 was first introduced by commit
:::::: 45847575ba9c8837017d2a6af498aaeee0477b3c riscv: compat: signal: Add rt_frame implementation

:::::: TO: Guo Ren <guoren@...ux.alibaba.com>
:::::: CC: Guo Ren <guoren@...ux.alibaba.com>

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ