linux-kernel - Re: [csky-linux:riscv_compat_v8 20/20] arch/riscv/kernel/compat_signal.c:199:5: warning: no previous prototype for function 'compat_setup_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1atu-azCPCC_1c-MKTungkHVn0Wd1awhZ4=hf1i9MWfA@mail.gmail.com>
Date:   Wed, 16 Mar 2022 14:55:34 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Guo Ren <guoren@...ux.alibaba.com>
Cc:     kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev,
        kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [csky-linux:riscv_compat_v8 20/20] arch/riscv/kernel/compat_signal.c:199:5:
 warning: no previous prototype for function 'compat_setup_rt_frame'

On Wed, Mar 16, 2022 at 2:42 PM kernel test robot <lkp@...el.com> wrote:
>
> All warnings (new ones prefixed by >>):
>
> >> arch/riscv/kernel/compat_signal.c:199:5: warning: no previous prototype for function 'compat_setup_rt_frame' [-Wmissing-prototypes]
>    int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
>        ^
>    arch/riscv/kernel/compat_signal.c:199:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
>    ^
>    static
>    1 warning generated.

The problem here is that the compat_setup_rt_frame() declaration got added to
arch/riscv/kernel/signal.c instead of a header file that is included by both
signal.c and compat_signal.c.

Alternatively, the definition could be made static and moved into signal.c.

       Arnd