linux-kernel - [PATCH v2 3/3] hwmon: (adt7475) Use enum chips when loading attenuator settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Mar 2022 11:30:50 +1300
From:   Chris Packham <chris.packham@...iedtelesis.co.nz>
To:     jdelvare@...e.com, linux@...ck-us.net, robh+dt@...nel.org
Cc:     linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Chris Packham <chris.packham@...iedtelesis.co.nz>
Subject: [PATCH v2 3/3] hwmon: (adt7475) Use enum chips when loading attenuator settings

Simplify load_attenuators() by making use of enum chips instead of int.

Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
---

Notes:
    Changes in v2:
    - New

 drivers/hwmon/adt7475.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 6de501de41b2..ebe4a85eb62e 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1569,7 +1569,7 @@ static int set_property_bit(const struct i2c_client *client, char *property,
 	return ret;
 }
 
-static int load_attenuators(const struct i2c_client *client, int chip,
+static int load_attenuators(const struct i2c_client *client, enum chips chip,
 			    struct adt7475_data *data)
 {
 	int ret;
@@ -1588,7 +1588,7 @@ static int load_attenuators(const struct i2c_client *client, int chip,
 						data->config4);
 		if (ret < 0)
 			return ret;
-	} else if (chip == adt7473 || chip == adt7475) {
+	} else {
 		set_property_bit(client, "adi,bypass-attenuator-in1",
 				 &data->config2, 5);
 
-- 
2.35.1