linux-kernel - Re: [PATCH v2 3/3] hwmon: (adt7475) Use enum chips when loading attenuator settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Mar 2022 07:32:23 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     jdelvare@...e.com, robh+dt@...nel.org, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] hwmon: (adt7475) Use enum chips when loading
 attenuator settings

On Fri, Mar 18, 2022 at 11:30:50AM +1300, Chris Packham wrote:
> Simplify load_attenuators() by making use of enum chips instead of int.
> 

That isn't the only thing the patch is doing.

> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
> 
> Notes:
>     Changes in v2:
>     - New
> 
>  drivers/hwmon/adt7475.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
> index 6de501de41b2..ebe4a85eb62e 100644
> --- a/drivers/hwmon/adt7475.c
> +++ b/drivers/hwmon/adt7475.c
> @@ -1569,7 +1569,7 @@ static int set_property_bit(const struct i2c_client *client, char *property,
>  	return ret;
>  }
>  
> -static int load_attenuators(const struct i2c_client *client, int chip,
> +static int load_attenuators(const struct i2c_client *client, enum chips chip,
>  			    struct adt7475_data *data)
>  {
>  	int ret;
> @@ -1588,7 +1588,7 @@ static int load_attenuators(const struct i2c_client *client, int chip,
>  						data->config4);
>  		if (ret < 0)
>  			return ret;
> -	} else if (chip == adt7473 || chip == adt7475) {
> +	} else {

This is the real change. Well, in theory. It doesn't really make a difference,
it is just (currently) unnecessary but clarifies that the following code only
applies to the two chips. It may be better to replace the if/else with a switch
statement to clarify this. Dropping the conditional would not require to change
the parameter type. That only really adds value if you also use a switch
statement (without dummy default).

Thanks,
Guenter

>  		set_property_bit(client, "adi,bypass-attenuator-in1",
>  				 &data->config2, 5);
>