| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <YjKr5vU6Vu8iW8VL@iweiny-desk3>
Date: Wed, 16 Mar 2022 20:32:54 -0700
From: Ira Weiny <ira.weiny@...el.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org,
"Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Paolo Bonzini <pbonzini@...hat.com>,
Stefan Hajnoczi <stefanha@...hat.com>,
Jens Axboe <axboe@...nel.dk>, Amit Shah <amit@...nel.org>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Eli Cohen <eli@...lanox.com>,
Saeed Mahameed <saeedm@...dia.com>,
Leon Romanovsky <leon@...nel.org>,
Pablo Neira Ayuso <pablo@...filter.org>,
Jozsef Kadlecsik <kadlec@...filter.org>,
Florian Westphal <fw@...len.de>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Felipe Balbi <felipe.balbi@...ux.intel.com>,
Michał Mirosław <mirq-linux@...e.qmqm.pl>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Krzysztof Opasiak <k.opasiak@...sung.com>,
Igor Kotrasinski <i.kotrasinsk@...sung.com>,
Valentina Manea <valentina.manea.m@...il.com>,
Shuah Khan <shuah@...nel.org>,
Shuah Khan <skhan@...uxfoundation.org>,
Jussi Kivilinna <jussi.kivilinna@...et.fi>,
Joachim Fritschi <jfritschi@...enet.de>,
Herbert Xu <herbert@...dor.apana.org.au>,
Thomas Gleixner <tglx@...utronix.de>,
Steven Rostedt <rostedt@...dmis.org>,
Ingo Molnar <mingo@...nel.org>,
Karol Herbst <karolherbst@...il.com>,
Pekka Paalanen <ppaalanen@...il.com>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Andy Lutomirski <luto@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Borislav Petkov <bp@...en8.de>,
"H. Peter Anvin" <hpa@...or.com>, netfilter-devel@...r.kernel.org,
coreteam@...filter.org, netdev@...r.kernel.org,
linux-block@...r.kernel.org, linux-crypto@...r.kernel.org,
linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org,
linux-usb@...r.kernel.org, nouveau@...ts.freedesktop.org,
virtualization@...ts.linux-foundation.org, x86@...nel.org
Subject: Re: [PATCH 0/9] treewide: eliminate anonymous module_init &
module_exit
On Wed, Mar 16, 2022 at 12:20:01PM -0700, Randy Dunlap wrote:
> There are a number of drivers that use "module_init(init)" and
> "module_exit(exit)", which are anonymous names and can lead to
> confusion or ambiguity when reading System.map, crashes/oops/bugs,
> or an initcall_debug log.
>
> Give each of these init and exit functions unique driver-specific
> names to eliminate the anonymous names.
I'm not fully sure about the Fixes tags but I don't see that it hurts anything.
For the series:
Reviewed-by: Ira Weiny <ira.weiny@...el.com>
>
> Example 1: (System.map)
> ffffffff832fc78c t init
> ffffffff832fc79e t init
> ffffffff832fc8f8 t init
> ffffffff832fca05 t init
> ffffffff832fcbd2 t init
> ffffffff83328f0e t init
> ffffffff8332c5b1 t init
> ffffffff8332d9eb t init
> ffffffff8332f0aa t init
> ffffffff83330e25 t init
> ffffffff833317a5 t init
> ffffffff8333dd6b t init
>
> Example 2: (initcall_debug log)
> calling init+0x0/0x12 @ 1
> initcall init+0x0/0x12 returned 0 after 15 usecs
> calling init+0x0/0x60 @ 1
> initcall init+0x0/0x60 returned 0 after 2 usecs
> calling init+0x0/0x9a @ 1
> initcall init+0x0/0x9a returned 0 after 74 usecs
> calling init+0x0/0x73 @ 1
> initcall init+0x0/0x73 returned 0 after 6 usecs
> calling init+0x0/0x73 @ 1
> initcall init+0x0/0x73 returned 0 after 4 usecs
> calling init+0x0/0xf5 @ 1
> initcall init+0x0/0xf5 returned 0 after 27 usecs
> calling init+0x0/0x7d @ 1
> initcall init+0x0/0x7d returned 0 after 11 usecs
> calling init+0x0/0xc9 @ 1
> initcall init+0x0/0xc9 returned 0 after 19 usecs
> calling init+0x0/0x9d @ 1
> initcall init+0x0/0x9d returned 0 after 37 usecs
> calling init+0x0/0x63f @ 1
> initcall init+0x0/0x63f returned 0 after 411 usecs
> calling init+0x0/0x171 @ 1
> initcall init+0x0/0x171 returned 0 after 61 usecs
> calling init+0x0/0xef @ 1
> initcall init+0x0/0xef returned 0 after 3 usecs
>
> Cc: "Michael S. Tsirkin" <mst@...hat.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Cc: Stefan Hajnoczi <stefanha@...hat.com>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: Amit Shah <amit@...nel.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Eli Cohen <eli@...lanox.com>
> Cc: Saeed Mahameed <saeedm@...dia.com>
> Cc: Leon Romanovsky <leon@...nel.org>
> Cc: Pablo Neira Ayuso <pablo@...filter.org>
> Cc: Jozsef Kadlecsik <kadlec@...filter.org>
> Cc: Florian Westphal <fw@...len.de>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
> Cc: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Cc: Krzysztof Opasiak <k.opasiak@...sung.com>
> Cc: Igor Kotrasinski <i.kotrasinsk@...sung.com>
> Cc: Valentina Manea <valentina.manea.m@...il.com>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> Cc: Jussi Kivilinna <jussi.kivilinna@...et.fi>
> Cc: Joachim Fritschi <jfritschi@...enet.de>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Karol Herbst <karolherbst@...il.com>
> Cc: Pekka Paalanen <ppaalanen@...il.com>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: netfilter-devel@...r.kernel.org
> Cc: coreteam@...filter.org
> Cc: netdev@...r.kernel.org
> Cc: linux-block@...r.kernel.org
> Cc: linux-crypto@...r.kernel.org
> Cc: linux-rdma@...r.kernel.org
> Cc: linux-scsi@...r.kernel.org
> Cc: linux-usb@...r.kernel.org
> Cc: nouveau@...ts.freedesktop.org
> Cc: virtualization@...ts.linux-foundation.org
> Cc: x86@...nel.org
>
> patches:
> [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit
> [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit
> [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit
> [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit
> [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit
> [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit
> [PATCH 7/9] usb: usbip: eliminate anonymous module_init & module_exit
> [PATCH 8/9] x86/crypto: eliminate anonymous module_init & module_exit
> [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit
>
> diffstat:
> arch/x86/crypto/blowfish_glue.c | 8 ++++----
> arch/x86/crypto/camellia_glue.c | 8 ++++----
> arch/x86/crypto/serpent_avx2_glue.c | 8 ++++----
> arch/x86/crypto/twofish_glue.c | 8 ++++----
> arch/x86/crypto/twofish_glue_3way.c | 8 ++++----
> arch/x86/mm/testmmiotrace.c | 8 ++++----
> drivers/block/virtio_blk.c | 8 ++++----
> drivers/char/virtio_console.c | 8 ++++----
> drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 ++++----
> drivers/scsi/virtio_scsi.c | 8 ++++----
> drivers/usb/gadget/legacy/inode.c | 8 ++++----
> drivers/usb/gadget/legacy/serial.c | 10 +++++-----
> drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++----
> drivers/usb/usbip/vudc_main.c | 8 ++++----
> net/ipv4/netfilter/nf_nat_h323.c | 8 ++++----
> 15 files changed, 61 insertions(+), 61 deletions(-)
Powered by blists - more mailing lists