linux-kernel - Re: [PATCH] macintosh: via-cuda: Fix warning comparing pointer to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2cec39d-fce4-9181-63fb-fde90f1f9a86@csgroup.eu>
Date:   Thu, 17 Mar 2022 08:44:34 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Haowen Bai <baihaowen@...zu.com>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "adobriyan@...il.com" <adobriyan@...il.com>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] macintosh: via-cuda: Fix warning comparing pointer to 0

Hi,

Le 17/03/2022 à 03:40, Haowen Bai a écrit :
> Avoid pointer type value compared with 0 to make code clear.

We already have this change waiting in the queue, see 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220214010558.130201-1-yang.lee@linux.alibaba.com/

Thanks
Christophe

> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>   drivers/macintosh/via-cuda.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/macintosh/via-cuda.c b/drivers/macintosh/via-cuda.c
> index cd267392..05a3cd9 100644
> --- a/drivers/macintosh/via-cuda.c
> +++ b/drivers/macintosh/via-cuda.c
> @@ -236,10 +236,10 @@ int __init find_via_cuda(void)
>       const u32 *reg;
>       int err;
>   
> -    if (vias != 0)
> +    if (vias)
>   	return 1;
>       vias = of_find_node_by_name(NULL, "via-cuda");
> -    if (vias == 0)
> +    if (!vias)
>   	return 0;
>   
>       reg = of_get_property(vias, "reg", NULL);
> @@ -517,7 +517,7 @@ cuda_write(struct adb_request *req)
>       req->reply_len = 0;
>   
>       spin_lock_irqsave(&cuda_lock, flags);
> -    if (current_req != 0) {
> +    if (current_req) {
>   	last_req->next = req;
>   	last_req = req;
>       } else {