linux-kernel - [martineau:kbuild-mptcp-enabled 7/19] net/mptcp/pm_netlink.c:397:23: warning: variable 'pernet' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 17 Mar 2022 19:26:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kishen Maloor <kishen.maloor@...el.com>
Cc:     kbuild-all@...ts.01.org, mathew.j.martineau@...ux.intel.com,
        linux-kernel@...r.kernel.org
Subject: [martineau:kbuild-mptcp-enabled 7/19] net/mptcp/pm_netlink.c:397:23:
 warning: variable 'pernet' set but not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/martineau/linux.git kbuild-mptcp-enabled
head:   1842e2df09dac50790d935c8db37aae18f7ad5ab
commit: 11b70f473e519350157fa74fefbdb6d12a99a199 [7/19] mptcp: handle local addrs announced by userspace PMs
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220317/202203171940.XUdtPaZP-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/martineau/linux.git/commit/?id=11b70f473e519350157fa74fefbdb6d12a99a199
        git remote add martineau https://git.kernel.org/pub/scm/linux/kernel/git/martineau/linux.git
        git fetch --no-tags martineau kbuild-mptcp-enabled
        git checkout 11b70f473e519350157fa74fefbdb6d12a99a199
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash net/mptcp/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   net/mptcp/pm_netlink.c: In function 'mptcp_free_local_addr_list':
>> net/mptcp/pm_netlink.c:397:23: warning: variable 'pernet' set but not used [-Wunused-but-set-variable]
     397 |  struct pm_nl_pernet *pernet;
         |                       ^~~~~~
   At top level:
   net/mptcp/pm_netlink.c:902:12: warning: 'mptcp_userspace_pm_append_new_local_addr' defined but not used [-Wunused-function]
     902 | static int mptcp_userspace_pm_append_new_local_addr(struct mptcp_sock *msk,
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/pernet +397 net/mptcp/pm_netlink.c

   392	
   393	void mptcp_free_local_addr_list(struct mptcp_sock *msk)
   394	{
   395		struct mptcp_pm_addr_entry *entry, *tmp;
   396		struct sock *sk = (struct sock *)msk;
 > 397		struct pm_nl_pernet *pernet;
   398		LIST_HEAD(free_list);
   399	
   400		if (!mptcp_pm_is_userspace(msk))
   401			return;
   402	
   403		pernet = net_generic(sock_net(sk), pm_nl_pernet_id);
   404	
   405		mptcp_data_lock(sk);
   406		list_splice_init(&msk->local_addr_list, &free_list);
   407		mptcp_data_unlock(sk);
   408	
   409		list_for_each_entry_safe(entry, tmp, &free_list, list) {
   410			sock_kfree_s(sk, entry, sizeof(*entry));
   411		}
   412	}
   413	

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org