lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Mar 2022 13:58:53 -0700 From: Reinette Chatre <reinette.chatre@...el.com> To: Shaopeng Tan <tan.shaopeng@...fujitsu.com>, Fenghua Yu <fenghua.yu@...el.com>, Shuah Khan <shuah@...nel.org> CC: <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>, "Shuah Khan" <skhan@...uxfoundation.org> Subject: Re: [PATCH v6 3/6] selftests/resctrl: Fix resctrl_tests' return code to work with selftest framework Hi Shaopeng Tan, On 3/18/2022 12:58 AM, Shaopeng Tan wrote: > In kselftest framework, if a sub test can not run by some reasons, > the test result should be marked as SKIP rather than FAIL. > Return KSFT_SKIP(4) instead of KSFT_FAIL(1) if resctrl_tests is not run > as root or it is run on a test environment which does not support resctrl. > > - ksft_exit_fail_msg(): returns KSFT_FAIL(1) > - ksft_exit_skip(): returns KSFT_SKIP(4) > > Reviewed-by: Shuah Khan <skhan@...uxfoundation.org> > Signed-off-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com> > --- > tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c > index 973f09a66e1e..ed7e1a995b01 100644 > --- a/tools/testing/selftests/resctrl/resctrl_tests.c > +++ b/tools/testing/selftests/resctrl/resctrl_tests.c > @@ -205,7 +205,7 @@ int main(int argc, char **argv) > * 2. We execute perf commands > */ > if (geteuid() != 0) > - return ksft_exit_fail_msg("Not running as root, abort testing.\n"); > + return ksft_exit_skip("Not running as root. Skipping...\n"); > > /* Detect AMD vendor */ > detect_amd(); > @@ -235,7 +235,7 @@ int main(int argc, char **argv) > sprintf(bm_type, "fill_buf"); > > if (!check_resctrlfs_support()) > - return ksft_exit_fail_msg("resctrl FS does not exist\n"); > + return ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL config options.\n"); > > filter_dmesg(); > Almost. "config options" -> "config option" With that fixed you can add: Reviewed-by: Reinette Chatre <reinette.chatre@...el.com> Reinette
Powered by blists - more mailing lists