[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9e02d88a-3344-8d91-c652-72cb989506de@linuxfoundation.org>
Date: Fri, 18 Mar 2022 14:59:05 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Fabio Estevam <festevam@...il.com>,
Felipe Balbi <balbi@...nel.org>,
Florian Fainelli <f.fainelli@...il.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Giulio Benetti <giulio.benetti@...ettiengineering.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Hans Verkuil <hverkuil@...all.nl>,
Heiko Stuebner <heiko@...ech.de>,
Heungjun Kim <riverful.kim@...sung.com>,
Houlong Wei <houlong.wei@...iatek.com>,
Hugues Fruchet <hugues.fruchet@...s.st.com>,
Hyun Kwon <hyun.kwon@...inx.com>,
Jacek Anaszewski <jacek.anaszewski@...il.com>,
Jacob Chen <jacob-chen@...wrt.com>,
Jaroslav Kysela <perex@...ex.cz>,
Jean-Christophe Trotin <jean-christophe.trotin@...s.st.com>,
Jeff LaBundy <jeff@...undy.com>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Jerome Brunet <jbrunet@...libre.com>,
Joe Hung <joe_hung@...tek.com>, Joel Stanley <joel@....id.au>,
Jonathan Hunter <jonathanh@...dia.com>,
Kevin Hilman <khilman@...libre.com>,
Kieran Bingham <kieran.bingham@...asonboard.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
Kyungmin Park <kyungmin.park@...sung.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Ludovic Desroches <ludovic.desroches@...rochip.com>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Marek Vasut <marex@...x.de>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Martina Krasteva <martinax.krasteva@...el.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Maxime Ripard <mripard@...nel.org>,
Michael Grzeschik <m.grzeschik@...gutronix.de>,
Michael Tretter <m.tretter@...gutronix.de>,
Michal Simek <michal.simek@...inx.com>,
Mike Isely <isely@...ox.com>, Ming Qian <ming.qian@....com>,
Minghsiu Tsai <minghsiu.tsai@...iatek.com>,
Mirela Rabulea <mirela.rabulea@....com>,
NXP Linux Team <linux-imx@....com>,
Neil Armstrong <narmstrong@...libre.com>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Nicolas Saenz Julienne <nsaenz@...nel.org>,
Olivier Lorin <o.lorin@...oste.net>,
Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
Pavel Machek <pavel@....cz>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Philipp Zabel <p.zabel@...gutronix.de>,
Randy Dunlap <rdunlap@...radead.org>,
Ray Jui <rjui@...adcom.com>,
Rick Chang <rick.chang@...iatek.com>,
Robert Foss <robert.foss@...aro.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Scott Branden <sbranden@...adcom.com>,
Sean Young <sean@...s.org>, Shawn Guo <shawnguo@...nel.org>,
Shawn Tu <shawnx.tu@...el.com>,
Shijie Qin <shijie.qin@....com>,
Sowjanya Komatineni <skomatineni@...dia.com>,
Stanimir Varbanov <stanimir.varbanov@...aro.org>,
Steve Longerbeam <slongerbeam@...il.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Takashi Iwai <tiwai@...e.com>,
Thierry Reding <thierry.reding@...il.com>,
Tianshu Qiu <tian.shu.qiu@...el.com>,
Tiffany Lin <tiffany.lin@...iatek.com>,
Todor Tomov <todor.too@...il.com>,
Vincent Knecht <vincent.knecht@...loo.org>,
Yong Deng <yong.deng@...ewell.com>,
Yong Zhi <yong.zhi@...el.com>, Zhou Peng <eagle.zhou@....com>,
alsa-devel@...a-project.org, bcm-kernel-feedback-list@...adcom.com,
linux-amlogic@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
linux-arm-msm@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org,
linux-rockchip@...ts.infradead.org,
linux-rpi-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-stm32@...md-mailman.stormreply.com,
linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
linux-usb@...r.kernel.org, mjpeg-users@...ts.sourceforge.net,
openbmc@...ts.ozlabs.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 64/64] media: Kconfig: cleanup VIDEO_DEV dependencies
On 3/14/22 1:55 AM, Mauro Carvalho Chehab wrote:
> media Kconfig has two entries associated to V4L API:
> VIDEO_DEV and VIDEO_V4L2.
>
> On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
> VIDEO_DEV were meant to:
> 1) enable Video4Linux and make its Kconfig options to appear;
> 2) it makes the Kernel build the V4L core.
>
> while VIDEO_V4L2 where used to distinguish between drivers that
> implement the newer API and drivers that implemented the former one.
>
> With time, such meaning changed, specially after the removal of
> all V4L version 1 drivers.
>
> At the current implementation, VIDEO_DEV only does (1): it enables
> the media options related to V4L, that now has:
>
> menu "Video4Linux options"
> visible if VIDEO_DEV
>
> source "drivers/media/v4l2-core/Kconfig"
> endmenu
>
> but it doesn't affect anymore the V4L core drivers.
>
> The rationale is that the V4L2 core has a "soft" dependency
> at the I2C bus, and now requires to select a number of other
> Kconfig options:
>
> config VIDEO_V4L2
> tristate
> depends on (I2C || I2C=n) && VIDEO_DEV
> select RATIONAL
> select VIDEOBUF2_V4L2 if VIDEOBUF2_CORE
> default (I2C || I2C=n) && VIDEO_DEV
>
> In the past, merging them would be tricky, but it seems that it is now
> possible to merge those symbols, in order to simplify V4L dependencies.
>
> Let's keep VIDEO_DEV, as this one is used on some make *defconfig
> configurations.
>
> Suggested-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@...nel.org>
> ---
>
> drivers/media/test-drivers/vicodec/Kconfig | 2 +-
> drivers/media/test-drivers/vimc/Kconfig | 2 +-
> drivers/media/test-drivers/vivid/Kconfig | 2 +-
>
For vimc change: (trimmed the recipient list to send response)
Acked-by: Shuah Khan <skhan@...uxfoundation.org>
thanks,
-- Shuah
Powered by blists - more mailing lists