linux-kernel - Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support EDAC on imx8mp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6729d4cd-45df-f554-708b-d353dc522cdf@kernel.org>
Date:   Sat, 19 Mar 2022 15:37:50 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Sherry Sun <sherry.sun@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support
 EDAC on imx8mp

On 19/03/2022 10:53, Sherry Sun wrote:
> Hi Krzysztof,
> 
>> Subject: Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support
>> EDAC on imx8mp
>>
>> On 18/03/2022 12:35, Sherry Sun wrote:
>>> i.MX8MP use synopsys V3.70a ddr controller IP, so add edac support for
>>> i.MX8MP based on "snps,ddrc-3.80a" synopsys edac driver.
>>
>> One more point - I think it might be worth to add dedicated compatible for
>> v3.70, as it is clearly a different version (with fallback to v3.80a).
> 
> Thanks for the review, I have check the V3.70a and V3.80a Synopsys ddr controller databook, there is no difference for the inline ECC part.
> So do you think we still need to add a new compatible for V3.70a even the EDAC driver operation is totally same with V3.80a?
> 

Thanks for checking. In such case you don't have to add the compatible.
It still might be beneficial in case there is some difference in
hardware, but looks like not required.


Best regards,
Krzysztof