linux-kernel - Re: [PATCH] tpm/tpm_ftpm_tee: Return true/false (not 1/0) from bool functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YjeY+7CI6n7gUdVX@kernel.org>
Date:   Sun, 20 Mar 2022 23:13:31 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     peterhuewe@....de, jgg@...pe.ca, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm/tpm_ftpm_tee: Return true/false (not 1/0) from bool
 functions

On Fri, Mar 18, 2022 at 11:35:25AM +0800, Haowen Bai wrote:
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> functions.
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>  drivers/char/tpm/tpm_ftpm_tee.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 6e32355..5c23342 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -177,7 +177,7 @@ static u8 ftpm_tee_tpm_op_status(struct tpm_chip *chip)
>  
>  static bool ftpm_tee_tpm_req_canceled(struct tpm_chip *chip, u8 status)
>  {
> -	return 0;
> +	return false;
>  }
>  
>  static const struct tpm_class_ops ftpm_tee_tpm_ops = {
> -- 
> 2.7.4
> 

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko