linux-kernel - RE: [PATCH v2] ufs: qcom: drop custom Android boot parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <004d01d83d39$fe7859c0$fb690d40$@samsung.com>
Date:   Mon, 21 Mar 2022 21:10:27 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        "'Andy Gross'" <agross@...nel.org>,
        "'Bjorn Andersson'" <bjorn.andersson@...aro.org>,
        "'Avri Altman'" <avri.altman@....com>,
        "'James E.J. Bottomley'" <jejb@...ux.ibm.com>,
        "'Martin K. Petersen'" <martin.petersen@...cle.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Cc:     "'Amit Pundir'" <amit.pundir@...aro.org>,
        "'Luca Weiss'" <luca.weiss@...rphone.com>,
        "'Brian Masney'" <bmasney@...hat.com>
Subject: RE: [PATCH v2] ufs: qcom: drop custom Android boot parameters



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzk@...nel.org]
>Sent: Monday, March 21, 2022 8:49 PM
>To: Andy Gross <agross@...nel.org>; Bjorn Andersson
><bjorn.andersson@...aro.org>; Alim Akhtar <alim.akhtar@...sung.com>;
>Avri Altman <avri.altman@....com>; James E.J. Bottomley
><jejb@...ux.ibm.com>; Martin K. Petersen <martin.petersen@...cle.com>;
>linux-arm-msm@...r.kernel.org; linux-scsi@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Cc: Krzysztof Kozlowski <krzk@...nel.org>; Amit Pundir
><amit.pundir@...aro.org>; Luca Weiss <luca.weiss@...rphone.com>; Brian
>Masney <bmasney@...hat.com>
>Subject: [PATCH v2] ufs: qcom: drop custom Android boot parameters
>
>The QCOM UFS driver requires an androidboot.bootdevice command line
>argument matching the UFS device name.  If the name is different, it
refuses
>to probe.  This androidboot.bootdevice is provided by stock/vendor (from an
>Android-based device) bootloader.
>
>This does not make sense from Linux point of view.  Driver should be able
to
>boot regardless of bootloader.  Driver should not depend on some Android
>custom environment data.
>
>Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>Tested-by: Amit Pundir <amit.pundir@...aro.org>
>Tested-by: Luca Weiss <luca.weiss@...rphone.com>
>Reviewed-by: Brian Masney <bmasney@...hat.com>
>Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

>---
>
>Changes since v1
>1. Fix commit msg typo (Alim).
>2. Add tags.
>
>See also:
>https://lore.kernel.org/linux-devicetree/f61abc2b-3ce8-7b1f-3d28-
>8a4a03ec58eb@...nel.org/T/#u
>---
> drivers/scsi/ufs/ufs-qcom.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index
>0d2e950d0865..586c0e567ff9 100644
>--- a/drivers/scsi/ufs/ufs-qcom.c
>+++ b/drivers/scsi/ufs/ufs-qcom.c
>@@ -957,18 +957,6 @@ static const struct reset_control_ops
>ufs_qcom_reset_ops = {
> 	.deassert = ufs_qcom_reset_deassert,
> };
>
>-#define	ANDROID_BOOT_DEV_MAX	30
>-static char android_boot_dev[ANDROID_BOOT_DEV_MAX];
>-
>-#ifndef MODULE
>-static int __init get_android_boot_dev(char *str) -{
>-	strlcpy(android_boot_dev, str, ANDROID_BOOT_DEV_MAX);
>-	return 1;
>-}
>-__setup("androidboot.bootdevice=", get_android_boot_dev); -#endif
>-
> /**
>  * ufs_qcom_init - bind phy with controller
>  * @hba: host controller instance
>@@ -988,9 +976,6 @@ static int ufs_qcom_init(struct ufs_hba *hba)
> 	struct resource *res;
> 	struct ufs_clk_info *clki;
>
>-	if (strlen(android_boot_dev) && strcmp(android_boot_dev,
>dev_name(dev)))
>-		return -ENODEV;
>-
> 	host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
> 	if (!host) {
> 		err = -ENOMEM;
>--
>2.32.0