linux-kernel - Re: [PATCH v2] ufs: qcom: drop custom Android boot parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd07c344-87cd-b64f-8418-d2b767a424b7@kernel.org>
Date:   Tue, 22 Mar 2022 19:14:46 +0100
From:   'Krzysztof Kozlowski' <krzk@...nel.org>
To:     Alim Akhtar <alim.akhtar@...sung.com>,
        'Andy Gross' <agross@...nel.org>,
        'Bjorn Andersson' <bjorn.andersson@...aro.org>,
        'Avri Altman' <avri.altman@....com>,
        "'James E.J. Bottomley'" <jejb@...ux.ibm.com>,
        "'Martin K. Petersen'" <martin.petersen@...cle.com>,
        linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     'Amit Pundir' <amit.pundir@...aro.org>,
        'Luca Weiss' <luca.weiss@...rphone.com>,
        'Brian Masney' <bmasney@...hat.com>
Subject: Re: [PATCH v2] ufs: qcom: drop custom Android boot parameters

On 21/03/2022 16:40, Alim Akhtar wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzk@...nel.org]
>> Sent: Monday, March 21, 2022 8:49 PM
>> To: Andy Gross <agross@...nel.org>; Bjorn Andersson
>> <bjorn.andersson@...aro.org>; Alim Akhtar <alim.akhtar@...sung.com>;
>> Avri Altman <avri.altman@....com>; James E.J. Bottomley
>> <jejb@...ux.ibm.com>; Martin K. Petersen <martin.petersen@...cle.com>;
>> linux-arm-msm@...r.kernel.org; linux-scsi@...r.kernel.org; linux-
>> kernel@...r.kernel.org
>> Cc: Krzysztof Kozlowski <krzk@...nel.org>; Amit Pundir
>> <amit.pundir@...aro.org>; Luca Weiss <luca.weiss@...rphone.com>; Brian
>> Masney <bmasney@...hat.com>
>> Subject: [PATCH v2] ufs: qcom: drop custom Android boot parameters
>>
>> The QCOM UFS driver requires an androidboot.bootdevice command line
>> argument matching the UFS device name.  If the name is different, it
> refuses
>> to probe.  This androidboot.bootdevice is provided by stock/vendor (from an
>> Android-based device) bootloader.
>>
>> This does not make sense from Linux point of view.  Driver should be able
> to
>> boot regardless of bootloader.  Driver should not depend on some Android
>> custom environment data.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>> Tested-by: Amit Pundir <amit.pundir@...aro.org>
>> Tested-by: Luca Weiss <luca.weiss@...rphone.com>
>> Reviewed-by: Brian Masney <bmasney@...hat.com>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>>
> 
> Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

Ah, sorry, I think I missed your Rb from v1.


Best regards,
Krzysztof