linux-kernel - Re: [PATCH 1/1] xen/blkfront: fix comment for need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Mar 2022 11:05:22 +0100
From:   Roger Pau Monné <roger.pau@...rix.com>
To:     Dongli Zhang <dongli.zhang@...cle.com>
CC:     <linux-block@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
        <boris.ostrovsky@...cle.com>, <jgross@...e.com>,
        <sstabellini@...nel.org>, <axboe@...nel.dk>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] xen/blkfront: fix comment for need_copy

On Thu, Mar 17, 2022 at 03:09:30PM -0700, Dongli Zhang wrote:
> The 'need_copy' is set when rq_data_dir(req) returns WRITE, in order to
> copy the written data to persistent page.
> 
> ".need_copy = rq_data_dir(req) && info->feature_persistent,"

I would also add:

Fixes: c004a6fe0c40 ('block/xen-blkfront: Make it running on 64KB page granularity')

> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>

Acked-by: Roger Pau Monné <roger.pau@...rix.com>

Albeit I have one nit since you are already changing the line.

> ---
>  drivers/block/xen-blkfront.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 03b5fb341e58..dbc32d0a4b1a 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -576,7 +576,7 @@ struct setup_rw_req {
>  	struct blkif_request *ring_req;
>  	grant_ref_t gref_head;
>  	unsigned int id;
> -	/* Only used when persistent grant is used and it's a read request */
> +	/* Only used when persistent grant is used and it's a write request */

While there you might want to adjust the comment to:

"... persistent grants are used ..."

Thanks, Roger.