linux-kernel - Re: [PATCH 1/1] xen/blkfront: fix comment for need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9143f2f8-9f96-66f4-0020-64918481606c@suse.com>
Date:   Mon, 21 Mar 2022 11:26:58 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Roger Pau Monné <roger.pau@...rix.com>,
        Dongli Zhang <dongli.zhang@...cle.com>
Cc:     linux-block@...r.kernel.org, xen-devel@...ts.xenproject.org,
        boris.ostrovsky@...cle.com, sstabellini@...nel.org,
        axboe@...nel.dk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] xen/blkfront: fix comment for need_copy

On 21.03.22 11:05, Roger Pau Monné wrote:
> On Thu, Mar 17, 2022 at 03:09:30PM -0700, Dongli Zhang wrote:
>> The 'need_copy' is set when rq_data_dir(req) returns WRITE, in order to
>> copy the written data to persistent page.
>>
>> ".need_copy = rq_data_dir(req) && info->feature_persistent,"
> 
> I would also add:
> 
> Fixes: c004a6fe0c40 ('block/xen-blkfront: Make it running on 64KB page granularity')

Hmm, a "Fixes:" tag for a change in a comment?

This might generate additional work e.g. for downstreams (we at SUSE have
scripts checking "Fixes:" tags and require such changes to be applied to
kernels having the fixed patch applied).

That said I'd prefer not having a "Fixes:" tag for such changes, but maybe
this is just due to the fact that it would be me having to apply this
patch to the SUSE kernels...


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)