[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <748d87c6-3f91-8bc0-ce8f-0a64278b4122@nvidia.com>
Date: Mon, 21 Mar 2022 18:24:21 +0530
From: Sumit Gupta <sumitg@...dia.com>
To: Jon Hunter <jonathanh@...dia.com>, <rafael@...nel.org>,
<viresh.kumar@...aro.org>, <robh+dt@...nel.org>,
<krzk+dt@...nel.org>, <treding@...dia.com>,
<linux-pm@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <ksitaraman@...dia.com>, <sanjayc@...dia.com>, <bbasu@...dia.com>,
"Sumit Gupta" <sumitg@...dia.com>
Subject: Re: [Patch v1 2/3] arm64: tegra: add node for tegra234 cpufreq
>> Adding cclpex node to represent Tegra234 cpufreq.
>> Tegra234 uses some of the CRAB (Control Register Access Bus)
>> registers for cpu frequency requests. These registers are
>> memory mapped to CCPLEX_MMCRAB_ARM region. In this node, mapping
>> the range of MMCRAB registers required only for cpu frequency info.
>>
>> Signed-off-by: Sumit Gupta <sumitg@...dia.com>
>> ---
>> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> index aaace605bdaa..610207f3f967 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> @@ -1258,6 +1258,13 @@
>> };
>> };
>> + ccplex@...0000 {
>> + compatible = "nvidia,tegra234-ccplex-cluster";
>> + reg = <0x0 0x0e000000 0x0 0x5ffff>;
>> + nvidia,bpmp = <&bpmp>;
>> + status = "okay";
>> + };
>> +
>> sram@...00000 {
>> compatible = "nvidia,tegra234-sysram", "mmio-sram";
>> reg = <0x0 0x40000000 0x0 0x80000>;
>
>
> We need to add this compatible string to a DT binding doc somewhere.
It seems the binding doc was previously posted in [1] for T186 SoC.
Same will be applicable for T234 SoC also. Only compatible string need
to be added.
Should I sent a separate patch after converting it to yaml format and
add compatible string (or) send as part of v2.
[1] https://lkml.org/lkml/2017/4/3/324
>
> Cheers
> Jon
>
Powered by blists - more mailing lists