linux-kernel - Re: [PATCH linux-next] selftests/vDSO: fix array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <489c8759-27c6-c71f-987d-3fc6d255f3b8@linuxfoundation.org>
Date:   Tue, 22 Mar 2022 17:01:01 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Guo Zhengkui <guozhengkui@...o.com>, Shuah Khan <shuah@...nel.org>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     zhengkui_guo@...look.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH linux-next] selftests/vDSO: fix array_size.cocci warning

On 3/20/22 11:27 PM, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> 
> tools/testing/selftests/vDSO/vdso_test_correctness.c:309:46-47:
> WARNING: Use ARRAY_SIZE
> tools/testing/selftests/vDSO/vdso_test_correctness.c:373:46-47:
> WARNING: Use ARRAY_SIZE
> 
> It has been tested with gcc (Debian 8.3.0-6) 8.3.0 on x86_64.
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>
> ---
>   tools/testing/selftests/vDSO/vdso_test_correctness.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_correctness.c b/tools/testing/selftests/vDSO/vdso_test_correctness.c
> index c4aea794725a..e691a3cf1491 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_correctness.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_correctness.c
> @@ -20,6 +20,7 @@
>   #include <limits.h>
>   
>   #include "vdso_config.h"
> +#include "../kselftest.h"
>   
>   static const char **name;
>   
> @@ -306,10 +307,8 @@ static void test_clock_gettime(void)
>   		return;
>   	}
>   
> -	for (int clock = 0; clock < sizeof(clocknames) / sizeof(clocknames[0]);
> -	     clock++) {
> +	for (int clock = 0; clock < ARRAY_SIZE(clocknames); clock++)
>   		test_one_clock_gettime(clock, clocknames[clock]);
> -	}
>   
>   	/* Also test some invalid clock ids */
>   	test_one_clock_gettime(-1, "invalid");
> @@ -370,10 +369,8 @@ static void test_clock_gettime64(void)
>   		return;
>   	}
>   
> -	for (int clock = 0; clock < sizeof(clocknames) / sizeof(clocknames[0]);
> -	     clock++) {
> +	for (int clock = 0; clock < ARRAY_SIZE(clocknames); clock++)
>   		test_one_clock_gettime64(clock, clocknames[clock]);
> -	}
>   
>   	/* Also test some invalid clock ids */
>   	test_one_clock_gettime64(-1, "invalid");
> 

Looks good to me. I will apply this once merge window closes.

thanks,
-- Shuah