linux-kernel - Re: [PATCH linux-next] selftests/proc: fix array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb5dd04b-a20c-1874-e71e-60c962ad8dcb@linuxfoundation.org>
Date:   Tue, 22 Mar 2022 17:02:11 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Guo Zhengkui <guozhengkui@...o.com>, Shuah Khan <shuah@...nel.org>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Cc:     zhengkui_guo@...look.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH linux-next] selftests/proc: fix array_size.cocci warning

On 3/21/22 4:25 AM, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> 
> tools/testing/selftests/proc/proc-pid-vm.c:371:26-27:
> WARNING: Use ARRAY_SIZE
> tools/testing/selftests/proc/proc-pid-vm.c:420:26-27:
> WARNING: Use ARRAY_SIZE
> 
> It has been tested with gcc (Debian 8.3.0-6) 8.3.0 on x86_64.
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>
> ---
>   tools/testing/selftests/proc/proc-pid-vm.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/proc/proc-pid-vm.c b/tools/testing/selftests/proc/proc-pid-vm.c
> index 18a3bde8bc96..28604c9f805c 100644
> --- a/tools/testing/selftests/proc/proc-pid-vm.c
> +++ b/tools/testing/selftests/proc/proc-pid-vm.c
> @@ -46,6 +46,8 @@
>   #include <sys/time.h>
>   #include <sys/resource.h>
>   
> +#include "../kselftest.h"
> +
>   static inline long sys_execveat(int dirfd, const char *pathname, char **argv, char **envp, int flags)
>   {
>   	return syscall(SYS_execveat, dirfd, pathname, argv, envp, flags);
> @@ -368,7 +370,7 @@ int main(void)
>   		};
>   		int i;
>   
> -		for (i = 0; i < sizeof(S)/sizeof(S[0]); i++) {
> +		for (i = 0; i < ARRAY_SIZE(S); i++) {
>   			assert(memmem(buf, rv, S[i], strlen(S[i])));
>   		}
>   
> @@ -417,7 +419,7 @@ int main(void)
>   		};
>   		int i;
>   
> -		for (i = 0; i < sizeof(S)/sizeof(S[0]); i++) {
> +		for (i = 0; i < ARRAY_SIZE(S); i++) {
>   			assert(memmem(buf, rv, S[i], strlen(S[i])));
>   		}
>   	}
> 

Looks good to me. I will apply this once merge window closes.


thanks,
-- Shuah