[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220322083614.GL23316@hu-pkondeti-hyd.qualcomm.com>
Date: Tue, 22 Mar 2022 14:06:14 +0530
From: Pavan Kondeti <quic_pkondeti@...cinc.com>
To: Sandeep Maheswaram <quic_c_sanm@...cinc.com>
CC: Bjorn Andersson <bjorn.andersson@...aro.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Felipe Balbi <balbi@...nel.org>,
Stephen Boyd <swboyd@...omium.org>,
Doug Anderson <dianders@...omium.org>,
"Matthias Kaehlcke" <mka@...omium.org>,
Mathias Nyman <mathias.nyman@...el.com>,
<linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <quic_pkondeti@...cinc.com>,
<quic_ppratap@...cinc.com>
Subject: Re: [PATCH v11 4/5] usb: dwc3: qcom: Configure wakeup interrupts
during suspend
Hi Sandeep,
On Tue, Mar 22, 2022 at 12:37:55PM +0530, Sandeep Maheswaram wrote:
> Configure interrupts based on hs_phy_mode to avoid triggering of
> interrupts during system suspend and suspend the device successfully.
>
The changelog is not clear and confusing. Can you elaborate please?
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@...cinc.com>
> Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 7352124..9804a19 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -316,22 +316,36 @@ static void dwc3_qcom_disable_wakeup_irq(int irq)
>
> static void dwc3_qcom_disable_interrupts(struct dwc3_qcom *qcom)
> {
> - dwc3_qcom_disable_wakeup_irq(qcom->hs_phy_irq);
> + struct dwc3 *dwc = platform_get_drvdata(qcom->dwc3);
>
> - dwc3_qcom_disable_wakeup_irq(qcom->dp_hs_phy_irq);
> + dwc3_qcom_disable_wakeup_irq(qcom->hs_phy_irq);
>
> - dwc3_qcom_disable_wakeup_irq(qcom->dm_hs_phy_irq);
> + if (dwc->hs_phy_mode & PHY_MODE_USB_HOST_LS) {
> + dwc3_qcom_disable_wakeup_irq(qcom->dp_hs_phy_irq);
> + } else if (dwc->hs_phy_mode & PHY_MODE_USB_HOST_HS) {
> + dwc3_qcom_disable_wakeup_irq(qcom->dm_hs_phy_irq);
> + } else {
> + dwc3_qcom_disable_wakeup_irq(qcom->dp_hs_phy_irq);
> + dwc3_qcom_disable_wakeup_irq(qcom->dm_hs_phy_irq);
> + }
Thanks,
Pavan
Powered by blists - more mailing lists