linux-kernel - Re: [PATCH v5 5/6] dax: fix missing writeprotect the pte entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YjmK0aaCu/FI/t7T@infradead.org>
Date:   Tue, 22 Mar 2022 01:37:37 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Muchun Song <songmuchun@...edance.com>
Cc:     dan.j.williams@...el.com, willy@...radead.org, jack@...e.cz,
        viro@...iv.linux.org.uk, akpm@...ux-foundation.org,
        apopple@...dia.com, shy828301@...il.com, rcampbell@...dia.com,
        hughd@...gle.com, xiyuyang19@...an.edu.cn,
        kirill.shutemov@...ux.intel.com, zwisler@...nel.org,
        hch@...radead.org, linux-fsdevel@...r.kernel.org,
        nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, duanxiongchun@...edance.com, smuchun@...il.com
Subject: Re: [PATCH v5 5/6] dax: fix missing writeprotect the pte entry

> +static void dax_entry_mkclean(struct address_space *mapping, unsigned long pfn,
> +			      unsigned long npfn, pgoff_t start)
>  {
>  	struct vm_area_struct *vma;
> +	pgoff_t end = start + npfn - 1;
>  
>  	i_mmap_lock_read(mapping);
> +	vma_interval_tree_foreach(vma, &mapping->i_mmap, start, end) {
> +		pfn_mkclean_range(pfn, npfn, start, vma);
>  		cond_resched();
>  	}
>  	i_mmap_unlock_read(mapping);


Is there any point in even keeping this helper vs just open coding it
in the only caller below?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>