linux-kernel - Re: [PATCH V8 07/22] LoongArch: Add atomic/locking headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0rJi35Bx+_Joq1NH79Pvd-+hNV8apDv5othr0_7_SqcQ@mail.gmail.com>
Date:   Tue, 22 Mar 2022 10:23:53 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        Guo Ren <guoren@...nel.org>,
        Palmer Dabbelt <palmer@...belt.com>
Subject: Re: [PATCH V8 07/22] LoongArch: Add atomic/locking headers

On Tue, Mar 22, 2022 at 4:03 AM Huacai Chen <chenhuacai@...nel.org> wrote:
> On Mon, Mar 21, 2022 at 5:42 PM Arnd Bergmann <arnd@...db.de> wrote:
> > On Sat, Mar 19, 2022 at 3:31 PM Huacai Chen <chenhuacai@...nel.org> wrote:

> > Please coordinate the inclusion of the patches with them and use that
> > spinlock implementation for the initial merge, to avoid further discussion
> > on the topic. If at a later point you are able to come up with a qspinlock
> > implementation that has convincing forward-progress guarantees and
> > can be shown to be better, we can revisit this.
>
> In my opinion, forward-progress is solved in V2, since we have
> reworked __xchg_small()/__cmpxchg_small(), and qspinlock is needed by
> NUMA.
> However, if the generic ticket lock is merged later, I will try to use
> it at present.

Yes, please do. If I merge both the ticket spinlock code and your architecture
code through the asm-generic tree for 5.19, this should work out nicely.

I'd good to hear that you have a solution for the forward-progress
issue with qspinlock, We should discuss that when the architecture
is merged then, and see what this means for the other architectures
that currently use the qspinlock code, to decide which ones of those
should be converted to ticket lock, which can use the same approach
that you have, and which are already safe.

        Arnd