linux-kernel - Re: [PATCH 03/11] libata: Send internal commands through the block layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Mar 2022 12:20:57 +0100
From:   Christoph Hellwig <hch@....de>
To:     John Garry <john.garry@...wei.com>
Cc:     axboe@...nel.dk, damien.lemoal@...nsource.wdc.com,
        bvanassche@....org, jejb@...ux.ibm.com, martin.petersen@...cle.com,
        hch@....de, ming.lei@...hat.com, hare@...e.de,
        chenxiang66@...ilicon.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
        linux-scsi@...r.kernel.org, dm-devel@...hat.com, beanhuo@...ron.com
Subject: Re: [PATCH 03/11] libata: Send internal commands through the block
 layer

On Tue, Mar 22, 2022 at 06:39:37PM +0800, John Garry wrote:
> When SCSI HBA device drivers are required to process an ATA internal
> command they still need a tag for the IO. This often requires the driver
> to set aside a set of tags for these sorts of IOs and manage the tags
> themselves.
> 
> If we associate a SCSI command (and request) with an ATA internal command
> then the tag is already provided, so introduce the change to send ATA
> internal commands through the block layer with a set of custom blk-mq ops.
> 
> note: I think that the timeout handling needs to be fixed up.

Any reason to not just send them through an ATA_16 passthrough CDB and
just use all the normal SCSI command handling?