linux-kernel - Re: [PATCH 04/11] scsi: libsas: Send SMP commands through the block layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220322112331.GD29270@lst.de>
Date:   Tue, 22 Mar 2022 12:23:31 +0100
From:   Christoph Hellwig <hch@....de>
To:     John Garry <john.garry@...wei.com>
Cc:     axboe@...nel.dk, damien.lemoal@...nsource.wdc.com,
        bvanassche@....org, jejb@...ux.ibm.com, martin.petersen@...cle.com,
        hch@....de, ming.lei@...hat.com, hare@...e.de,
        chenxiang66@...ilicon.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
        linux-scsi@...r.kernel.org, dm-devel@...hat.com, beanhuo@...ron.com
Subject: Re: [PATCH 04/11] scsi: libsas: Send SMP commands through the
 block layer

Wouldn't it make more sense to have a new member in th Scsi_Host_template
that gets called for these request early from ->queue_rq instead of the
new request_queue and custome ops?

FYI, I think reusing the block layer for all these command is a good
idea but the way it is done here seems a bit ugly and not very
maintainable.