linux-kernel - Re: [PATCH] gpio: Drop CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfbs6sPsrjwxNWLZQu=pEoar2K5sY=fX9a7KkOe=mwsZw@mail.gmail.com>
Date:   Tue, 22 Mar 2022 16:37:13 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Jianqun Xu <jay.xu@...k-chips.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: Drop CONFIG_DEBUG_GPIO

On Fri, Mar 11, 2022 at 4:55 AM Brian Norris <briannorris@...omium.org> wrote:

...

> Description: it says nothing about enabling extra printk()s. But -DDEBUG
> does just that; it turns on every dev_dbg()/pr_debug() that would
> otherwise be silent.

Which is what some and I are using a lot during development.

...

> -ccflags-$(CONFIG_DEBUG_GPIO)   += -DDEBUG
> -

NAK to this change.

I'm not against enabling might_sleep() unconditionally.

-- 
With Best Regards,
Andy Shevchenko