linux-kernel - Re: [PATCH 2/9] dt-bindings: soc: apple: Add ANS NVMe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40f7c074-198a-5ce0-02b3-e6042975e228@kernel.org>
Date:   Wed, 23 Mar 2022 12:14:32 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Sven Peter <sven@...npeter.dev>, Rob Herring <robh+dt@...nel.org>
Cc:     Hector Martin <marcan@...can.st>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Arnd Bergmann <arnd@...db.de>, Keith Busch <kbusch@...nel.org>,
        Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Marc Zyngier <maz@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org
Subject: Re: [PATCH 2/9] dt-bindings: soc: apple: Add ANS NVMe

On 21/03/2022 17:50, Sven Peter wrote:
> Apple SoCs such as the M1 come with an embedded NVMe coprocessor called
> ANS2.
> 
> Signed-off-by: Sven Peter <sven@...npeter.dev>
> ---
>  .../bindings/soc/apple/apple,nvme-ans.yaml    | 75 +++++++++++++++++++
>  1 file changed, 75 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/apple/apple,nvme-ans.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/apple/apple,nvme-ans.yaml b/Documentation/devicetree/bindings/soc/apple/apple,nvme-ans.yaml
> new file mode 100644
> index 000000000000..e1f4c1c572aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/apple/apple,nvme-ans.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/apple/apple,nvme-ans.yaml#

Do not drop all code in soc/apple, but please use respective subsystems.
Apple is not a subsystem, is not special.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple ANS NVM Express host controller
> +
> +maintainers:
> +  - Sven Peter <sven@...npeter.dev>
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - apple,t8103-nvme-ans2
> +          - apple,t6000-nvme-ans2
> +      - const: apple,nvme-ans2
> +
> +  reg:
> +    items:
> +      - description: NVMe and NVMMU registers
> +      - description: ANS2 co-processor control registers
> +
> +  reg-names:
> +    items:
> +      - const: nvme
> +      - const: ans
> +
> +  resets:
> +    maxItems: 1
> +
> +  power-domains: true

maxItems



Best regards,
Krzysztof