linux-kernel - RE: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Mar 2022 01:54:35 +0000
From:   qinjian[覃健] <qinjian@...lus1.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "maz@...nel.org" <maz@...nel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        Rob Herring <robh@...nel.org>
Subject: RE: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset
 driver

> > +examples:
> > +  - |
> > +    rstc: reset@...00054 {
> > +      compatible = "sunplus,sp7021-reset";
> > +      #reset-cells = <1>;
> > +      reg = <0x9c000054 0x28>;
> 
> I asked you to put the reg after compatible in all DTS code and
> examples. If you do not agree with a comment, please respond. Ignoring
> it is not cooperative.
> 

Your  reply: https://lore.kernel.org/all/d3ac3e2f-71fd-b2b4-7c7e-bb43c681d14e@canonical.com/
> > +  - |
> > +
> > +    clkc: clock-controller@...00000 {
> > +      compatible = "sunplus,sp7021-clkc";
> > +      #clock-cells = <1>;
> > +      reg = <0x9c000000 0x280>;
>
> In DTS code, please put reg after compatible. In all your examples and
> DTS patches.
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

I see your review-tag. So, I misunderstand your comments.
Did you means 'reg' must directly after the 'compatible', like this?
    clkc: clock-controller@...00000 {
      #clock-cells = <1>;
      compatible = "sunplus,sp7021-clkc";
      reg = <0x9c000000 0x280>;