linux-kernel - Re: [PATCH 1/1] x86/amd_nb: unexport amd_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yjs9X4O3qwamG6ul@zn.tnic>
Date:   Wed, 23 Mar 2022 16:31:43 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     "Chatradhi, Naveen Krishna" <nchatrad@....com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        linux-edac@...r.kernel.org, mingo@...hat.com, mchehab@...nel.org,
        airlied@...ux.ie, Muralidhara M K <muralimk@....com>
Subject: Re: [PATCH 1/1] x86/amd_nb: unexport amd_cache_northbridges()

On Wed, Mar 23, 2022 at 08:54:20PM +0530, Chatradhi, Naveen Krishna wrote:
> Modules that are using this API comes after the fs_initcall() is called.

I don't need you to explain this to me - I need you to:

"What I am missing in this commit message is why is it ok to do that?"

I.e., pls explain in the commit message exactly why it is ok to do that
so that people who read it, will know.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette