linux-kernel - Re: [PATCH -next] ASoC: tlv320adc3xxx: Fix build error when GPIOLIB is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YjtJJvHeslMokYEE@sirena.org.uk>
Date:   Wed, 23 Mar 2022 16:21:58 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Baisong Zhong <zhongbaisong@...wei.com>
Cc:     linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        srinivas.kandagatla@...aro.org, ckeepax@...nsource.cirrus.com,
        tanureal@...nsource.cirrus.com, cy_huang@...htek.com,
        pierre-louis.bossart@...ux.intel.com,
        drhodes@...nsource.cirrus.com, pbrobinson@...il.com,
        hdegoede@...hat.com, lukas.bulwahn@...il.com, ricardw@...s.com
Subject: Re: [PATCH -next] ASoC: tlv320adc3xxx: Fix build error when GPIOLIB
 is not set

On Wed, Mar 23, 2022 at 10:17:36PM +0800, Baisong Zhong wrote:

>  config SND_SOC_TLV320ADC3XXX
>  	tristate "Texas Instruments TLV320ADC3001/3101 audio ADC"
> -	depends on I2C
> +	depends on I2C && GPIOLIB

This is bogus, the device clearly doesn't require GPIOs to be useful and
so there shouldn't be a dependency on gpiolib which normally stubs out.
In general for APIs with stubs adding a config dependency is not the right
thing to do.

I suspect it's just a missing header.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)