linux-kernel - Re: [RFC PATCH 1/3] objtool: Move common code to utils.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2203231859420.10670@pobox.suse.cz>
Date:   Wed, 23 Mar 2022 19:02:47 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Sathvika Vasireddy <sv@...ux.ibm.com>
cc:     linuxppc-dev@...ts.ozlabs.org, jpoimboe@...hat.com,
        peterz@...radead.org, linux-kernel@...r.kernel.org, aik@...abs.ru,
        mpe@...erman.id.au, rostedt@...dmis.org,
        naveen.n.rao@...ux.vnet.ibm.com
Subject: Re: [RFC PATCH 1/3] objtool: Move common code to utils.c

> +#define sym_for_each_insn(file, sym, insn)                              \
> +	for (insn = find_insn(file, sym->sec, sym->offset);             \
> +	     insn && &insn->list != &file->insn_list &&                 \
> +		insn->sec == sym->sec &&                                \
> +		insn->offset < sym->offset + sym->len;                  \
> +	     insn = list_next_entry(insn, list))
> +
> +#endif /* UTILS_H */

Since you include <objtool/utils.h> in check.c, you can remove the 
definition of sym_for_each_insn() macro from check.c as well.

I wonder if it would make sense to move all these helper functions to 
utils.c and utils.h. Might be connected to what Josh wrote about his work 
on objtool interface.

Regards
Miroslav