linux-kernel - Re: [PATCH v2 1/4] scripts/get_feat.pl: allow output the parsed file names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874k3lg7r3.fsf@meer.lwn.net>
Date:   Fri, 25 Mar 2022 13:19:28 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] scripts/get_feat.pl: allow output the parsed
 file names

Mauro Carvalho Chehab <mchehab@...nel.org> writes:

> Such output could be helpful while debugging it, but its main
> goal is to tell kernel_feat.py about what files were used
> by the script. Thie way, kernel_feat.py can add those as
> documentation dependencies.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@...nel.org>

So I think these are worth getting into 5.18, but I do have one question:

> @@ -95,6 +97,10 @@ sub parse_feat {
>  	return if ($file =~ m,($prefix)/arch-support.txt,);
>  	return if (!($file =~ m,arch-support.txt$,));
>  
> +	if ($enable_fname) {
> +		printf "#define FILE %s\n", abs_path($file);
> +	}
> +

Why do you output the file names in this format?  This isn't input to
the C preprocessor, so the #define just seems strange.  What am I
missing here?

Thanks,

jon