linux-kernel - Re: [PATCH v19 1/4] Add flags option to get xattr method paired to __vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Mar 2022 10:44:31 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Luca Weiss <luca.weiss@...rphone.com>
Cc:     dvander@...gle.com, Luca.Boccassi@...rosoft.com,
        darrick.wong@...cle.com, dsterba@...e.com, hubcap@...ibond.com,
        jack@...e.cz, jlayton@...nel.org, kernel-team@...roid.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-unionfs@...r.kernel.org, paulmoore@...rosoft.com,
        salyzyn@...roid.com, sds@...ho.nsa.gov, selinux@...r.kernel.org
Subject: Re: [PATCH v19 1/4] Add flags option to get xattr method paired to __vfs_getxattr

On Fri, Mar 25, 2022 at 7:02 AM Luca Weiss <luca.weiss@...rphone.com> wrote:
>
> Hi David,
>
> this patch doesn't compile with CONFIG_SECURITY=n:
>
> ./include/linux/security.h: In function 'security_inode_need_killpriv':
> ./include/linux/security.h:893:40: error: passing argument 1 of 'cap_inode_need_killpriv' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   893 |         return cap_inode_need_killpriv(dentry);
>       |                                        ^~~~~~
>       |                                        |
>       |                                        struct dentry *
> ./include/linux/security.h:153:52: note: expected 'struct user_namespace *' but argument is of type 'struct dentry *'
>   153 | int cap_inode_need_killpriv(struct user_namespace *mnt_userns,
>       |                             ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
>
> I applied the patch on linux-next tag next-20220318, but the relevant part
> doesn't seem to have changed lately.

I believe David (and Google) have abandoned this patchset in favor of
another approach.  I'm possibly going to recycle some of the ideas in
this patchset for some future work, but the details are still TBD.

-- 
paul-moore.com