linux-kernel - RE: [PATCH v1 1/3] ARM: dts: aspeed: Add video engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HK0PR06MB23070E27C9104B3726CC245EE61A9@HK0PR06MB2307.apcprd06.prod.outlook.com>
Date:   Fri, 25 Mar 2022 01:56:59 +0000
From:   Howard Chiu <howard_chiu@...eedtech.com>
To:     Jae Hyun Yoo <quic_jaehyoo@...cinc.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Joel Stanley <joel@....id.au>,
        "andrew@...id.au" <andrew@...id.au>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 1/3] ARM: dts: aspeed: Add video engine

Hi Jae

> -----Original Message-----
> From: Jae Hyun Yoo <quic_jaehyoo@...cinc.com>
> Sent: Thursday, March 24, 2022 9:49 PM
> To: Howard Chiu <howard_chiu@...eedtech.com>; robh+dt@...nel.org; Joel
> Stanley <joel@....id.au>; andrew@...id.au; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-aspeed@...ts.ozlabs.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v1 1/3] ARM: dts: aspeed: Add video engine
> 
> Hi Howard,
> 
> On 3/24/2022 12:27 AM, Howard Chiu wrote:
> > The ast2600 SoC has an embedded video engine
> >
> > Signed-off-by: Howard Chiu <howard_chiu@...eedtech.com>
> > ---
> >   arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++++++++++
> >   1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi
> > b/arch/arm/boot/dts/aspeed-g6.dtsi
> > index c32e87fad4dc..41d5087f7d92 100644
> > --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> > @@ -389,6 +389,17 @@ sbc: secure-boot-controller@...f2000 {
> >   				reg = <0x1e6f2000 0x1000>;
> >   			};
> >
> > +			video: video@...00000 {
> > +				compatible = "aspeed,ast2600-video-engine";
> > +				reg = <0x1e700000 0x1000>;
> > +				clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
> > +					 <&syscon ASPEED_CLK_GATE_ECLK>;
> > +				clock-names = "vclk", "eclk";
> > +				interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > +				resets = <&syscon ASPEED_RESET_VIDEO>;
> 
> Video engine reset is handled by clk-ast2600.c so you don't need to add
> 'resets'.
> 
> > +				status = "disabled";
> > +			};
> > +
> 
> This node was already added back by this change.
> https://lore.kernel.org/all/CACPK8XfPPLoS=mhwbAHY4EfVad=1_dnhB+gaHBjPj
> 1wWbWE4gg@...l.gmail.com/
> 
Thanks for info, the next patchset won't include this.
> Cheers,
> 
> -Jae
> 
> >   			gpio0: gpio@...80000 {
> >   				#gpio-cells = <2>;
> >   				gpio-controller;