linux-kernel - drivers/video/fbdev/core/fbmem.c:1496:15: warning: no previous declaration for 'get_fb_unmapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 27 Mar 2022 01:01:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yannick Fertre <yannick.fertre@...com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Eric Anholt <eric@...olt.net>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: drivers/video/fbdev/core/fbmem.c:1496:15: warning: no previous
 declaration for 'get_fb_unmapped_area'

Hi Yannick,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52d543b5497cf31d6baeb0bcfe5a5474c3238578
commit: b759012c5fa761ee08998c80fc4ad6343c258487 drm/stm: Add STM32 LTDC driver
date:   4 years, 11 months ago
config: arm-randconfig-r023-20220326 (https://download.01.org/0day-ci/archive/20220327/202203270028.vzpaWr13-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b759012c5fa761ee08998c80fc4ad6343c258487
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout b759012c5fa761ee08998c80fc4ad6343c258487
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash M=drivers/video/fbdev/core

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/video/fbdev/core/fbmem.c:1496:15: warning: no previous declaration for 'get_fb_unmapped_area' [-Wmissing-declarations]
    unsigned long get_fb_unmapped_area(struct file *filp,
                  ^~~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbmem.c:719:37: warning: 'fb_proc_fops' defined but not used [-Wunused-const-variable=]
    static const struct file_operations fb_proc_fops = {
                                        ^~~~~~~~~~~~


vim +/get_fb_unmapped_area +1496 drivers/video/fbdev/core/fbmem.c

^1da177e4c3f415 drivers/video/fbmem.c            Linus Torvalds    2005-04-16  1494  
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1495  #ifdef CONFIG_FB_PROVIDE_GET_FB_UNMAPPED_AREA
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04 @1496  unsigned long get_fb_unmapped_area(struct file *filp,
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1497  				   unsigned long addr, unsigned long len,
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1498  				   unsigned long pgoff, unsigned long flags)
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1499  {
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1500  	struct fb_info * const info = filp->private_data;
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1501  	unsigned long fb_size = PAGE_ALIGN(info->fix.smem_len);
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1502  
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1503  	if (pgoff > fb_size || len > fb_size - pgoff)
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1504  		return -EINVAL;
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1505  
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1506  	return (unsigned long)info->screen_base + pgoff;
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1507  }
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1508  #endif
82f42e4cc164ed4 drivers/video/fbdev/core/fbmem.c Benjamin Gaignard 2017-01-04  1509  

:::::: The code at line 1496 was first introduced by commit
:::::: 82f42e4cc164ed486c9e2b1b74e65b176830d947 fbmem: add a default get_fb_unmapped_area function

:::::: TO: Benjamin Gaignard <benjamin.gaignard@...aro.org>
:::::: CC: Daniel Vetter <daniel.vetter@...ll.ch>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp