linux-kernel - Re: [PATCH v2 2/5] fpga: fpga-mgr: fix for coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d6100a8-4c5f-20d9-6c94-f08379e989ec@redhat.com>
Date:   Sat, 26 Mar 2022 10:03:06 -0700
From:   Tom Rix <trix@...hat.com>
To:     Nava kishore Manne <nava.manne@...inx.com>, mdf@...nel.org,
        hao.wu@...el.com, yilun.xu@...el.com, michal.simek@...inx.com,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, git@...inx.com
Subject: Re: [PATCH v2 2/5] fpga: fpga-mgr: fix for coding style issues


On 3/22/22 1:21 AM, Nava kishore Manne wrote:
> fixes the below checks reported by checkpatch.pl
> Lines should not end with a '('
> Alignment should match open parenthesis

There are more than a few similar alignments to clean up in drivers/fpga

Instead of just one, in a separate patchset, clean up all of them.

Tom

>
> Signed-off-by: Nava kishore Manne <nava.manne@...inx.com>
> ---
> Changes for v2:
> 		-None.
>
>   drivers/fpga/fpga-mgr.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> index d49a9ce34568..a699cc8e2fa6 100644
> --- a/drivers/fpga/fpga-mgr.c
> +++ b/drivers/fpga/fpga-mgr.c
> @@ -151,8 +151,8 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr,
>   	if (!mgr->mops->initial_header_size)
>   		ret = fpga_mgr_write_init(mgr, info, NULL, 0);
>   	else
> -		ret = fpga_mgr_write_init(
> -		    mgr, info, buf, min(mgr->mops->initial_header_size, count));
> +		ret = fpga_mgr_write_init(mgr, info, buf,
> +					  min(mgr->mops->initial_header_size, count));
>   
>   	if (ret) {
>   		dev_err(&mgr->dev, "Error preparing FPGA for writing\n");