linux-kernel - Re: [PATCH v1 4/4] hwmon: add driver for the Microchip LAN966x SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202203271141.S44Wx3yF-lkp@intel.com>
Date:   Sun, 27 Mar 2022 11:13:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Michael Walle <michael@...le.cc>, Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Michael Walle <michael@...le.cc>
Subject: Re: [PATCH v1 4/4] hwmon: add driver for the Microchip LAN966x SoC

Hi Michael,

I love your patch! Perhaps something to improve:

[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on robh/for-next linus/master v5.17 next-20220325]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Michael-Walle/hwmon-add-lan9668-driver/20220327-032606
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: sparc64-randconfig-s031-20220327 (https://download.01.org/0day-ci/archive/20220327/202203271141.S44Wx3yF-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/intel-lab-lkp/linux/commit/cfef456b1f1b1ab545a03f098e209aff8ae507b7
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Michael-Walle/hwmon-add-lan9668-driver/20220327-032606
        git checkout cfef456b1f1b1ab545a03f098e209aff8ae507b7
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sparc64 SHELL=/bin/bash drivers/hwmon/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/hwmon/lan966x-hwmon.c:302:24: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected struct regmap * @@     got void [noderef] __iomem *[assigned] base @@
   drivers/hwmon/lan966x-hwmon.c:302:24: sparse:     expected struct regmap *
   drivers/hwmon/lan966x-hwmon.c:302:24: sparse:     got void [noderef] __iomem *[assigned] base

vim +302 drivers/hwmon/lan966x-hwmon.c

   289	
   290	static struct regmap *lan966x_init_regmap(struct platform_device *pdev,
   291						  const char *name)
   292	{
   293		struct regmap_config regmap_config = {
   294			.reg_bits = 32,
   295			.reg_stride = 4,
   296			.val_bits = 32,
   297		};
   298		void __iomem *base;
   299	
   300		base = devm_platform_ioremap_resource_byname(pdev, name);
   301		if (IS_ERR(base))
 > 302			return base;
   303	
   304		regmap_config.name = name;
   305	
   306		return devm_regmap_init_mmio(&pdev->dev, base, &regmap_config);
   307	}
   308	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp