lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 27 Mar 2022 22:58:07 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Sergey Shtylyov <s.shtylyov@....ru> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Gregory CLEMENT <gregory.clement@...tlin.com>, Geert Uytterhoeven <geert+renesas@...der.be>, Fabien Dessenne <fabien.dessenne@...s.st.com>, Linus Walleij <linus.walleij@...aro.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>, linux-amlogic <linux-amlogic@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux-Renesas <linux-renesas-soc@...r.kernel.org>, linux-stm32@...md-mailman.stormreply.com, Neil Armstrong <narmstrong@...libre.com>, Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Andrew Lunn <andrew@...n.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Bartosz Golaszewski <brgl@...ev.pl> Subject: Re: [PATCH v1 5/5] pinctrl: armada-37xx: Replace custom code by gpiochip_count() call On Sat, Mar 26, 2022 at 7:02 PM Sergey Shtylyov <s.shtylyov@....ru> wrote: > On 3/25/22 11:03 PM, Andy Shevchenko wrote: > > > Since we have a generic function to count GPIO controller nodes > > under a given device, there is no need to open-code it. Replace > > custom code by gpiochip_count() call. ... > > + nr_child_nodes = of_irq_count(np); > > Mhm, 'np' is no longer assigned to it at this point... Good catch! We may retrieve it by calling np = to_of_node(device_get_named_child_node(dev, "gpio-controller")); like it's done in the previous patch in the series. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists