lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Mar 2022 22:46:19 +0530 From: Vinod Koul <vkoul@...nel.org> To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>, Abhinav Kumar <quic_abhinavk@...cinc.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Krishna Manikandan <mkrishn@...eaurora.org>, linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells On 28-03-22, 19:43, Dmitry Baryshkov wrote: > On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski > <krzysztof.kozlowski@...aro.org> wrote: > > > > The DSI node is not a bus and the children do not have unit addresses. > > > > Reported-by: Vinod Koul <vkoul@...nel.org> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> > > NAK. > DSI panels are children of the DSI device tree node with the reg = <0>; address. > This is the convention used by other platforms too (see e.g. > arch/arm64/boot/dts/freescale/imx8mq-evk.dts). So we should add reg = 0, i will update my dtsi fix > With the DSI split link it is possible to attach two panels to a > single DSI host, so addresses are necessary. > > > --- > > .../bindings/display/msm/dsi-controller-main.yaml | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > index 7095ec3c890d..57f238f72326 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > @@ -51,10 +51,6 @@ properties: > > phy-names: > > const: dsi > > > > - "#address-cells": true > > - > > - "#size-cells": true > > - > > syscon-sfpb: > > description: A phandle to mmss_sfpb syscon node (only for DSIv2). > > $ref: "/schemas/types.yaml#/definitions/phandle" > > @@ -154,9 +150,6 @@ examples: > > reg = <0x0ae94000 0x400>; > > reg-names = "dsi_ctrl"; > > > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > interrupt-parent = <&mdss>; > > interrupts = <4>; > > > > -- > > 2.32.0 > > > > > -- > With best wishes > Dmitry -- ~Vinod
Powered by blists - more mailing lists