linux-kernel - Re: [PATCH] mtd: spi-nor: fix minmax.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a20ed24-be9d-bbec-19da-56c0ff68cbda@ti.com>
Date:   Mon, 28 Mar 2022 11:28:30 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Julia Lawall <julia.lawall@...ia.fr>, <kbuild-all@...ts.01.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Amit Kumar Mahapatra <amit.kumar-mahapatra@...inx.com>,
        Michal Simek <monstr@...str.eu>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Michael Walle <michael@...le.cc>,
        Pratyush Yadav <p.yadav@...com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: fix minmax.cocci warnings

Hi.

On 26/03/22 2:00 pm, Julia Lawall wrote:
> From: kernel test robot <lkp@...el.com>
> 
> Use min to simplify the code.
> 
> Generated by: scripts/coccinelle/misc/minmax.cocci
> 
> Fixes: 2747bc2106aa ("mtd: spi-nor: Add dual parallel and stacked mode support")
> CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@...inx.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
> ---
> 
> tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
> head:   1870e0fa79a9d58c6748c34550f3ccea0b515933
> commit: 2747bc2106aa429773d9a932c799aa6229595148 [840/1029] mtd: spi-nor: Add dual parallel and stacked mode support
> :::::: branch date: 34 hours ago
> :::::: commit date: 8 weeks ago
> 
>  drivers/mtd/spi-nor/core.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -2034,10 +2034,7 @@ static int spi_nor_read(struct mtd_info
>  						(offset << nor->shift);
>  			}
>  		}
> -		if (len < rem_bank_len)
> -			read_len = len;
> -		else
> -			read_len = rem_bank_len;
> +		read_len = min(len, rem_bank_len);

This chunk does not exist in mainline. Seems like xlnx local changes.

Regards
Vignesh