linux-kernel - Re: [PATCH v2] char: tty3270: fix a missing check on list iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220328093831.28087-1-xiam0nd.tong@gmail.com>
Date:   Mon, 28 Mar 2022 17:38:31 +0800
From:   Xiaomeng Tong <xiam0nd.tong@...il.com>
To:     svens@...ux.ibm.com
Cc:     agordeev@...ux.ibm.com, borntraeger@...ux.ibm.com,
        dsterba@...e.com, elder@...aro.org, gor@...ux.ibm.com,
        gregkh@...uxfoundation.org, hca@...ux.ibm.com, jcmvbkbc@...il.com,
        jirislaby@...nel.org, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org, stable@...r.kernel.org,
        xiam0nd.tong@...il.com
Subject: Re: [PATCH v2] char: tty3270: fix a missing check on list iterator

> I should have written that in my first reply, but s == NULL means
> the given line number couldn't be found in the list of lines. This is
> a serious error and should be warned about. So maybe something like:
> 
> if (WARN_ON(!s))
> 	return;
> 
> But allocating a new empty line in that case is certainly wrong.

Thank you, i have resend a v3 patch as you suggested.

--
Xiaomeng Tong