linux-kernel - Re: [PATCH] block: restore the old set_task_ioprio() behaviour wrt PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220329065535.GA20158@lst.de>
Date:   Tue, 29 Mar 2022 08:55:35 +0200
From:   Christoph Hellwig <hch@....de>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] block: restore the old set_task_ioprio() behaviour wrt
 PF_EXITING

>  		task_lock(task);
>  		if (task->flags & PF_EXITING) {
> -			err = -ESRCH;
>  			kmem_cache_free(iocontext_cachep, ioc);
>  			goto out;

Please add a commnt here why we are not returning an error, otherwise
this is just getting "fixed" over and over again.