linux-kernel - Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r16li6e7.wl-maz@kernel.org>
Date:   Tue, 29 Mar 2022 08:07:12 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     yuzhe <yuzhe@...china.com>
Cc:     james.morse@....com, alexandru.elisei@....com,
        suzuki.poulose@....com, catalin.marinas@....com, will@...nel.org,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        linux-kernel@...r.kernel.org, liqiong@...china.com,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

On Tue, 29 Mar 2022 07:14:16 +0100,
yuzhe <yuzhe@...china.com> wrote:
> 
> >> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
> >>     static int vgic_debug_show(struct seq_file *s, void *v)
> >>   {
> >> -	struct kvm *kvm = (struct kvm *)s->private;
> >> +	struct kvm *kvm = s->private;
> >>   	struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
> > How about you fully get rid of the unnecessary casts then?
> > 
> > 	M.
> 
> I don't know what you exactly mean. I follow the
> kernel-janitors/TODO List to get rid of the unnecessary casts.  And
> I checked all the code in the arch directory and found these issues.

Let me quote the lines again:

> >>     static int vgic_debug_show(struct seq_file *s, void *v)
[...]
> >>   	struct vgic_state_iter *iter = (struct vgic_state_iter *)v;

Do you see what I mean?

	M.

-- 
Without deviation from the norm, progress is not possible.