linux-kernel - Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49b93407-dee3-b3bb-6d36-d6f94e9b16bf@nfschina.com>
Date:   Tue, 29 Mar 2022 15:26:11 +0800
From:   yuzhe <yuzhe@...china.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     james.morse@....com, alexandru.elisei@....com,
        suzuki.poulose@....com, catalin.marinas@....com, will@...nel.org,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        linux-kernel@...r.kernel.org, liqiong@...china.com,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

在 2022/3/29 15:07, Marc Zyngier 写道:

> On Tue, 29 Mar 2022 07:14:16 +0100,
> yuzhe <yuzhe@...china.com> wrote:
>>>> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
>>>>      static int vgic_debug_show(struct seq_file *s, void *v)
>>>>    {
>>>> -	struct kvm *kvm = (struct kvm *)s->private;
>>>> +	struct kvm *kvm = s->private;
>>>>    	struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
>>> How about you fully get rid of the unnecessary casts then?
>>>
>>> 	M.
>> I don't know what you exactly mean. I follow the
>> kernel-janitors/TODO List to get rid of the unnecessary casts.  And
>> I checked all the code in the arch directory and found these issues.
> Let me quote the lines again:
>
>>>>      static int vgic_debug_show(struct seq_file *s, void *v)
> [...]
>>>>    	struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
> Do you see what I mean?
>
> 	M.

Got it, thanks. I will check again and resubmit.

yuzhe