linux-kernel - Re: [PATCH] dt-bindings: PCI: uniphier: Convert uniphier-pcie.txt to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c71c397-c48f-46e4-1813-2d7fbb029be7@socionext.com>
Date:   Tue, 29 Mar 2022 19:55:23 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: uniphier: Convert uniphier-pcie.txt to
 json-schema

Hi Rob,

On 2022/03/29 1:23, Rob Herring wrote:
> On Mon, Mar 28, 2022 at 07:51:05AM -0500, Rob Herring wrote:
>> On Mon, 28 Mar 2022 11:11:38 +0900, Kunihiko Hayashi wrote:
>>> Convert the file into a JSON description at the yaml format.
>>>
>>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
>>> ---
>>>   .../bindings/pci/socionext,uniphier-pcie.yaml | 100
> ++++++++++++++++++
>>>   .../devicetree/bindings/pci/uniphier-pcie.txt |  82 --------------
>>>   MAINTAINERS                                   |   2 +-
>>>   3 files changed, 101 insertions(+), 83 deletions(-)
>>>   create mode 100644
> Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
>>>   delete mode 100644
> Documentation/devicetree/bindings/pci/uniphier-pcie.txt
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/1609988
>>
>>
>> pcie@...00000: compatible: ['socionext,uniphier-pcie', 'snps,dw-pcie']
> is too long
>> 	arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dt.yaml
>> 	arch/arm64/boot/dts/socionext/uniphier-ld20-global.dt.yaml
>> 	arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dt.yaml
>> 	arch/arm64/boot/dts/socionext/uniphier-pxs3-ref.dt.yaml
> 
> Ignore this if your intent is to fix these by dropping 'snps,dw-pcie'. I
> think that is the right thing to do. 'snps,dw-pcie' is not too
> meaningful.

I see. I should remove "snps,dw-pcie" from the existing devicetree, so
I'll fix it as a devicetree patch.

Thank you,

---
Best Regards
Kunihiko Hayashi