linux-kernel - Re: [PATCH] dt-bindings: PCI: uniphier: Convert uniphier-pcie.txt to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00796c28-7485-8710-b76b-ac94e3358387@socionext.com>
Date:   Tue, 29 Mar 2022 19:54:49 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: uniphier: Convert uniphier-pcie.txt to
 json-schema

Hi Rob,

Thank you for reviewing.

On 2022/03/29 1:22, Rob Herring wrote:
> On Mon, Mar 28, 2022 at 11:11:38AM +0900, Kunihiko Hayashi wrote:
>> Convert the file into a JSON description at the yaml format.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
>> ---
>>   .../bindings/pci/socionext,uniphier-pcie.yaml | 100 ++++++++++++++++++
>>   .../devicetree/bindings/pci/uniphier-pcie.txt |  82 --------------
>>   MAINTAINERS                                   |   2 +-
>>   3 files changed, 101 insertions(+), 83 deletions(-)
>>   create mode 100644
> Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
>>   delete mode 100644 Documentation/devicetree/bindings/pci/uniphier-pcie.
> txt

[snip]

>> +properties:
>> +  compatible:
>> +    enum:
>> +      - socionext,uniphier-pcie
>> +
>> +  reg:
>> +    minItems: 3
>> +    maxItems: 4
>> +
>> +  reg-names:
>> +    oneOf:
>> +      - items:
>> +          - const: dbi
>> +          - const: link
>> +          - const: config
>> +      - items:
>> +          - const: dbi
>> +          - const: link
>> +          - const: config
>> +          - const: atu
> 
> You can have just the 2nd list plus 'minItems: 3' to do the same thing.

I see. I'll rewrite it that way.

Thank you,

---
Best Regards
Kunihiko Hayashi